Re: [PATCH] connect bluetooth configs and examples to the build

From: Maksim Yevmenkin <m_evmenkin_at_yahoo.com>
Date: Tue, 21 Oct 2003 16:40:57 -0700 (PDT)
Simon,

> > i'd like to commit attached patch. the purpose is to connect etc/bluetooth
> > and share/examples/netgraph/bluetooth to the build. please review and let
> > me know if i missed anything.
> >
> > Index: src/etc/bluetooth/Makefile
> > ===================================================================
> > RCS file: src/etc/bluetooth/Makefile
> > diff -N src/etc/bluetooth/Makefile
> > --- /dev/null	1 Jan 1970 00:00:00 -0000
> > +++ src/etc/bluetooth/Makefile	21 Oct 2003 20:20:03 -0000
> > _at__at_ -0,0 +1,10 _at__at_
> > +# $Id: Makefile,v 1.1 2003/10/20 16:48:45 max Exp $
> > +# $FreeBSD$
> > +
> > +FILESDIR=		${DESTDIR}/etc/bluetooth
> 
> I'm rather sure that you shouldn't include DESTDIR, since bsd.files.mk
> does that. 

got it. thanks for noticing this :)

> Also you should probably use the style from
> style.Makefile(5) for new Makefile's.

could you please be more specific? i took a quick look at style.Makefile(5)
page and could not find anything related to my case.

thanks,
max

__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com
Received on Tue Oct 21 2003 - 14:40:59 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:26 UTC