Re: NO_WERROR: correct usage?

On Mon, Nov 08, 2004 at 10:38:15PM -0600, Conrad J. Sabatier wrote:
> The description in /usr/src/UPDATING re: the use of NO_WERROR seems to
> be incorrect:
> 
> 20020815:
>         A "bug" in gcc(1) that was hiding warning in system headers was
>         fixed.  It's probably time to add -DNO_WERROR to your make line
>         again.
> 
> Adding "-DNO_WERROR" to CFLAGS in /etc/make.conf seems to have no
> effect; the "-Werror" switch still gets added at certain places during
> the build.
> 
The above does NOT say you should be adding -DNO_WERROR to CFLAGS, it
says you should add it "to your make line", e.g.:

	make buildworld -DNO_WERROR

> On the other hand, defining NO_WERROR as a make variable in
> /etc/make.conf does seem to work, like so:
> 
> NO_WERROR=true
> 
True.  ;)

> In addition, for kernel builds, it appears that it is necessary to 
> define:
> 
> WERROR=-Wno-error 
> 
Or just define it to an empty value.


Cheers,
-- 
Ruslan Ermilov
ru_at_FreeBSD.org
FreeBSD committer