Re: [PATCH] nForce2 SMBus support

From: John Baldwin <jhb_at_freebsd.org>
Date: Fri, 9 Dec 2005 07:53:48 -0500
On Friday 09 December 2005 06:36 am, Artemiev Igor wrote:
> On Thu, 8 Dec 2005 09:51:51 -0500
>
> John Baldwin <jhb_at_freebsd.org> wrote:
> > > I simply do not see any way to do it with current implementation of
> > > ampdm(and also viapm, etc) & smbus, without modifying the smb-
> > >
> > > >smbus->smbus driver interface. I may be wrong, but as far as I
> > > >know, currently it's one
> > >
> > > smb for one driver (smbus_* limitation)
> >
> > Hmm, it doesn't specify the child device, just the parent.  *sigh*
> > That's lame.  You don't have to call it amdpmsub0 btw, you could just
> > call it amdpm1 if you wanted and have amdpm1 a child of amdpm0.  All
> > that would need to change for that is the NF2_SUBDEV string and the
> > DRIVER_MODULE line (it would be DRIVER_MODULE(amdpm, amdpm, ...)).
> > This has the added advantage that you don't have to patch smbus.c.
>
> I remade it as you described - can't understand, why I didn't think
> about it myself

Do you have a final patch at a URL?  If so, I'll go ahead and commit it for 
you.

-- 
John Baldwin <jhb_at_FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org
Received on Fri Dec 09 2005 - 11:54:11 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:48 UTC