Re: [PATCH] kbdmux(4) update

Markus,

[...]

>>> - one Logitech ps/2 mouse
>>> - one Logitech MX1000 bluetooth mouse
>>> - two Logitech MX900 bluetooth mice
>>> - one Cherry ps/2 keyboard
>>> - one Logitech MX5000 bluetooth keyboard
>>>
>>>working in parallel flawlessly :) I would say: Awesome work Maksim!
>>
>>did you have all these things connected at once? :) if so, then this is
>>quite an impressive collections :)
> 
> Yep. Only sideeffect was that my girlfriend was looking a bit strangly when 
> she watched me working with 2 keyboards and 4 mice at once :)

:) make a picture and post it somewhere :)

>>please give yourself a credit too. you picked up where i left with 
>>bthidd(8), found and fixed silly typos etc. thank you for doing this.
> 
> I hope to improve bthidd further in the near future. First thing will be a 
> clean way to handle the button problem (2 button mice vs. 3 button mice) and 
> the support for tilt wheels.

sounds good.

>>>>>Btw: I'm getting LORs from vkbd(4) when working with the bluetooth
>>>>>keyboard (6-STABLE from about an hour ago with the kndmux patch):
>>>>
>>>>thanks for reporting this. it has nothing to do with the kdbmux(4)
>>>>patch. it has been there for quite a long time. i will fix it.
>>>
>>>Thanks!
>>
>>could you please give a try to the following vkbd(4) patch?
>>
>>http://people.freebsd.org/~emax/vkbd.c.diff.txt
>>
>>this patch essentially removes custom locking from the vkbd(4) and makes
>>it rely on Giant mutex (just like the rest of keyboard drivers and
>>syscons(4) do).
> 
> The patch works great. No more LORs here.

thanks for testing. i have committed it to -current and will mfc it shortly.

thanks,
max