Re: Call for testing: emu10kx driver for Creative sound cards

From: Warner Losh <imp_at_bsdimp.com>
Date: Wed, 24 May 2006 09:26:59 -0600 (MDT)
From: "Yuriy Tsibizov" <Yuriy.Tsibizov_at_gfk.ru>
Subject: RE: Call for testing: emu10kx driver for Creative sound cards
Date: Wed, 24 May 2006 14:39:57 +0400

> > + .Pp
> > + Sysctl nodes provided by drivers should not be considered to be
> > + permanant unless they are documented in the driver's man page.
> > + Names which start with _ denote a tree or node which is considered
> > + impermanant and should not be relied up by code elsewhere in the
> > + system.
> > + Driver writers should use the sysctl infrastructure provided by
> > + .Xr device_get_sysctl_ctx 9 
> > + and
> > + .Xr device_get_sysctl_tree 9
> > + for their sysctls.
> > + Drivers should migrate from past interfaces to this new 
> > interface, but
> > + provide, where needed, backwards compatibility shims.
> > + These facilities export the sysctl as 
> > dev.<driver-name>.<unit>.attribute.
> 
> Should sound drivers (pcm* device) be documented as an exception from this? 
> They use snd_sysctl_tree_top() to get tree OID under hw.snd.pcmX and 
> snd_sysctl_tree() to get their context.

No.  They should not.  They should provide the old compatibility stuff
in the old place, but also provide it in the correct place.

Warner
Received on Wed May 24 2006 - 13:29:02 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:56 UTC