Re: Cosmetic path to bsdinstall

On 02/24/11 16:07, John Baldwin wrote:
> On Thursday, February 24, 2011 3:35:51 pm Nathan Whitehorn wrote:
>> On 02/24/11 14:14, John Baldwin wrote:
>>> On Thursday, February 24, 2011 10:00:44 am Nathan Whitehorn wrote:
>>>> Thanks! I've received basically this patch from a couple people now. I'm
>>>> going to investigate whether this is a more generic way to get this
>>>> information (so the list doesn't grow infinitely long), and will commit
>>>> this if I can't. Having CAM devices be part of newbus would simplify
>>>> this a very great deal...
>>> Note that all these disk devices are not CAM devices, so CAM changing to
>>> use new-bus wouldn't really matter one whit.  They do all show up as 'DISK'
>>> GEOM's however (I also hacked on a GEOM-based libdisk replacement at one
>>> point, though probably less developed than Marcel's.  I used libgeom to
>>> discover DISK devices.)  Given that disk_create() already hooks into GEOM,
>>> that is probably the right way to discover disks in a generic fashion.
>> Right, stepping through that is how I build the list. Adding a device
>> description to the XML actually seems like a good idea (and maybe the
>> drive serial number?). Would anyone have any objections to me starting
>> to go through and do that?
> I think that would be fine, but I don't think GEOM knows about those
> properties yet?

It doesn't, but the attached patch changes that. I've added a new field 
to struct disk (d_descr) meant to hold a human-readable description of 
the disk, and changed several drivers (cd, ada, ad) to fill it with 
their model strings. I've also modified geom_disk's config XML to report 
the disk ident and description. If there aren't any objections, I'll 
commit this at the end of the day.
-Nathan