Re: [PATCH] nvmecontrol breaks world

From: Steve Kargl <sgk_at_troutmask.apl.washington.edu>
Date: Tue, 2 Jul 2013 16:23:10 -0700
On Tue, Jul 02, 2013 at 10:30:53PM +0200, Ed Schouten wrote:
> 2013/7/2 Steve Kargl <sgk_at_troutmask.apl.washington.edu>:
> > Could someone (this could even be me, but need approval) please
> > fix nvmecontrol?
> 
> off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
> Also, the call of malloc(sb.st_size) is not really safe...
> 

jimharris committed the patch.  I suspect that this is intel
code, which needs to be portable to other OS's.  Hopefully,
he fixes the build soon. 

-- 
Steve
Received on Tue Jul 02 2013 - 21:23:12 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:39 UTC