Re: vn_fullpath: 0xc85e24a0 is not locked but should be

From: Jun Kuriyama <kuriyama_at_imgsrc.co.jp> Date: Tue, 16 Dec 2003 10:05:47 +0900 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:34 UTC

At Thu, 11 Dec 2003 23:14:50 -0500 (EST),
Robert Watson wrote:
> Index: procfs.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/fs/procfs/procfs.c,v
> retrieving revision 1.9
> diff -u -r1.9 procfs.c
> --- procfs.c	17 Apr 2003 22:12:12 -0000	1.9
> +++ procfs.c	12 Dec 2003 04:13:10 -0000
> _at__at_ -70,7 +70,9 _at__at_
>  	char *fullpath = "unknown";
>  	char *freepath = NULL;
>  
> +	vn_lock(p->p_textvp, LK_EXCLUSIVE | LK_RETRY, td);
>  	vn_fullpath(td, p->p_textvp, &fullpath, &freepath);
> +	VOP_UNLOCK(p->p_textvp, 0, td);
>  	sbuf_printf(sb, "%s", fullpath);
>  	if (freepath)
>  		free(freepath, M_TEMP);

I'm running my box with this patch (and DEBUG_VFS_LOCKS) and it seems
fine.

-- 
Jun Kuriyama <kuriyama_at_imgsrc.co.jp> // IMG SRC, Inc.
             <kuriyama_at_FreeBSD.org> // FreeBSD Project