Re: GEOM panic

From: Sean Kelly <smkelly_at_FreeBSD.org>
Date: Tue, 8 Jul 2003 15:46:49 -0500
On Tue, Jul 08, 2003 at 10:35:47PM +0200, Poul-Henning Kamp wrote:
> 
> Can you try this patch ?

...
> diff -u -r1.28 geom_dump.c
> --- geom_dump.c	11 Jun 2003 06:49:15 -0000	1.28
> +++ geom_dump.c	8 Jul 2003 20:00:45 -0000
...
> _at__at_ -162,6 +164,8 _at__at_
>  		sbuf_printf(sb, "\t  <provider ref=\"%p\"/>\n", cp->provider);
>  	sbuf_printf(sb, "\t  <mode>r%dw%de%d</mode>\n",
>  	    cp->acr, cp->acw, cp->ace);
> +	if (cp->geom->flags & G_GEOM_WITHER)
> +		;
>  	if (cp->geom->dumpconf != NULL) {
>  		sbuf_printf(sb, "\t  <config>\n");
...

Should that be "else if ((cp->geom->dumpconf != NULL)"? I don't know the
code, but I'm basing this question off of what is below in the patch:

> _at__at_ -182,7 +186,9 _at__at_
>  	sbuf_printf(sb, "\t  <mediasize>%jd</mediasize>\n",
>  	    (intmax_t)pp->mediasize);
>  	sbuf_printf(sb, "\t  <sectorsize>%u</sectorsize>\n", pp->sectorsize);
> -	if (pp->geom->dumpconf != NULL) {
> +	if (pp->geom->flags & G_GEOM_WITHER)
> +		;
> +	else if (pp->geom->dumpconf != NULL) {  // <---------- HERE
>  		sbuf_printf(sb, "\t  <config>\n");
>  		pp->geom->dumpconf(sb, "\t    ", pp->geom, NULL, pp);
>  		sbuf_printf(sb, "\t  </config>\n");

-- 
Sean Kelly          | PGP KeyID: D2E5E296
smkelly_at_FreeBSD.org | http://www.sean-kelly.org/
Received on Tue Jul 08 2003 - 11:46:52 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:14 UTC