Re: Witness panic (fxp/polling related)

From: Nate Lawson <nate_at_root.org>
Date: Fri, 11 Jul 2003 13:18:11 -0700 (PDT)
On Fri, 11 Jul 2003, John Baldwin wrote:
>         if (ether_poll_register(fxp_poll, ifp)) {
>                 /* disable interrupts */
>                 CSR_WRITE_1(sc, FXP_CSR_SCB_INTRCNTL, FXP_SCB_INTR_DISABLE);
>                 fxp_poll(ifp, 0, 1);
>                 FXP_UNLOCK(sc);
>                 return;
>
> Try moving the FXP_UNLOCK() up before the call to fxp_poll() (it
> should be safe to do so).

I looked it over and indeed this is the correct fix.  Please commit.

Thanks,
Nate
Received on Fri Jul 11 2003 - 11:18:10 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:14 UTC