Re: make release of CURRENT on 4.7 broken again ?

On Mon, Jul 21, 2003 at 06:08:43PM +0300, Ruslan Ermilov wrote:
> On Mon, Jul 21, 2003 at 02:13:45PM +0300, Andrey Elperin wrote:
> > On Sun, Jul 20, 2003 at 02:44:23PM +0300, Ruslan Ermilov wrote:
> > > >  A few days ago I've noticed such messages in CURRENT buildlog (on 4.7
> > > >  box, building without -j<something>) :
> > > > 
> > > > cc -Os -pipe -c chown_stub.c
> > > > ld -dc -r -o chown.lo chown_stub.o /usr/obj//usr/src/usr.sbin/chown/chown.o
> > > > crunchide -k _crunched_chown_stub chown.lo
> > > > echo "int _crunched_chroot_stub(int argc, char **argv, char **envp){return main(argc,argv,envp);}" >chroot_stub.c
> > > > cc -Os -pipe -c chroot_stub.c
> > > > ld -dc -r -o chroot.lo chroot_stub.o /usr/obj//usr/src/usr.sbin/chroot/chroot.o
> > > > crunchide -k _crunched_chroot_stub chroot.lo
> > > > cc -static -o fixit_crunch fixit_crunch.o cat.lo chmod.lo cp.lo dd.lo df.lo echo.lo expr.lo kill.lo ln.lo ls.lo mkdir.lo mv.lo rm.lo rmdir.lo sleep.lo sync.lo bsdlabel.lo clri.lo dmesg.lo fdisk.lo mknod.lo mount.lo mount_cd9660.lo mount_msdosfs.lo reboot.lo restore.lo swapon.lo umount.lo ftp.lo telnet.lo vi.lo chown.lo chroot.lo -ledit -lgeom -lkvm -lm -lncurses
> > > > -lutil
> > > > *** Error code 1
> > > >  
> > > > Stop in /usr/obj/usr/src/release/fixit_crunch.
> > > > *** Error code 1
> > > > 
> > > I have committed a fix for this to src/bin/ed/ a few minutes ago.
> > 
> >  Hmm. But I got the same error during last release building (this night).
> > 
> The "make -j" buildworld is currently broken by the recent changes
> to kerberos5/, and the issue is being worked out.  The breakage is
> mostly visible in the "4.x doing the build of 5.x" case, because
> the latter has /usr/include/roken.h and hides the building bug.
> At the moment, I'm retesting the snapshot build of 5.x on my 4.x
> SMP box without -j.  I will follow up with what I get.
> 
Yes, I can see the breakage:

: crunchide -k _crunched_vi_stub vi.lo
: echo "int _crunched_chown_stub(int argc, char **argv, char **envp){return main(a
: rgc,argv,envp);}" >chown_stub.c
: cc -Os -pipe -c chown_stub.c
: ld -dc -r -o chown.lo chown_stub.o /usr/obj//usr/src/usr.sbin/chown/chown.o
: crunchide -k _crunched_chown_stub chown.lo
: echo "int _crunched_chroot_stub(int argc, char **argv, char **envp){return main(
: argc,argv,envp);}" >chroot_stub.c
: cc -Os -pipe -c chroot_stub.c
: ld -dc -r -o chroot.lo chroot_stub.o /usr/obj//usr/src/usr.sbin/chroot/chroot.o
: crunchide -k _crunched_chroot_stub chroot.lo
: cc -static -o fixit_crunch fixit_crunch.o cat.lo chmod.lo cp.lo dd.lo df.lo echo
: .lo expr.lo kill.lo ln.lo ls.lo mkdir.lo mv.lo rm.lo rmdir.lo sleep.lo sync.lo b
: sdlabel.lo clri.lo dmesg.lo fdisk.lo mknod.lo mount.lo mount_cd9660.lo mount_msd
: osfs.lo reboot.lo restore.lo swapon.lo umount.lo ftp.lo telnet.lo vi.lo chown.lo
:  chroot.lo -ledit -lgeom -lkvm -lm -lncurses -lutil
: telnet.lo: In function `display':
: telnet.lo(.text+0x122e): undefined reference to `EncryptStatus'
: telnet.lo: In function `status':
: telnet.lo(.text+0x1e85): undefined reference to `encrypt_display'
: ...
: 
: telnet.lo(.data+0xaa0): undefined reference to `EncryptStatus'
: *** Error code 1
: 
: Stop in /usr/obj/usr/src/release/fixit_crunch.
: *** Error code 1
: 
: Stop in /usr/src/release.

I believe Mark has committed a fix for this today (commit log
is attached).


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru_at_sunbay.com		Sunbay Software Ltd,
ru_at_FreeBSD.org		FreeBSD committer

attached mail follows:

markm       2003/07/20 16:29:46 PDT

  FreeBSD src repository

  Modified files:
    lib/libtelnet        Makefile 
    libexec/telnetd      Makefile 
    usr.bin/telnet       Makefile 
  Log:
  Test correct macro for "without crypto" option(s).
  
  Revision  Changes    Path
  1.16      +1 -1      src/lib/libtelnet/Makefile
  1.21      +1 -1      src/libexec/telnetd/Makefile
  1.23      +1 -1      src/usr.bin/telnet/Makefile