Re: make release broken [FIX]

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Tue, 22 Jul 2003 15:07:01 -0400 (EDT)
On 22-Jul-2003 Ruslan Ermilov wrote:
> On Tue, Jul 22, 2003 at 02:45:52PM -0400, John Baldwin wrote:
>> 
>> On 22-Jul-2003 Ruslan Ermilov wrote:
>> > On Tue, Jul 22, 2003 at 02:26:34PM -0400, John Baldwin wrote:
>> >> 
>> >> On 22-Jul-2003 Ruslan Ermilov wrote:
>> >> > Hi!
>> >> > 
>> >> > As many of you probably know, recent telnet commit broke snapshot
>> >> > building.  Since I needed a working "make release" to go on with
>> >> > my task on floppy-less "make release" (for AMD64, etc.), I had to
>> >> > just fix it.  Attached is the patch.  It also fixes another issue
>> >> > with this telnet commit: it ensures that crypto telnet[d] do not
>> >> > end up in the "base" distribution.
>> >> 
>> >> Why not simply enable 'NO_FLOPPIES' on the arch's that don't want
>> >> floppies?
>> >> 
>> > Because NO_FLOPPIES doesn't mean like it sounds; it means "do not
>> > create floppy _images_", and we want to skip much more than that.
>> > I have a preliminary patch that is currently under the "make
>> > release" test.  Let me know (or anyone else) if you want to review
>> > it or the final version before I commit it.
>> 
>> Are you eliminating the mfsroot?
>> 
> Yes.

Ugh.

>> All the bootable CD's use
>> that right now, so what more are you doing than eliminating
>> the floppy images?
>> 
> Part of the patch for the iso.1 target has this (cut-n-pasted):
> 
> _at__at_ -885,10 +873,7 _at__at_
>  .if ${TARGET} != "pc98"
>         _at_echo "Setting up /boot"
>         _at_rm -f ${CD_DISC2}/boot/loader.conf
> -       _at_cp ${RD}/mfsroot/mfsroot.gz ${CD_DISC2}/boot/mfsroot.gz
> -       _at_echo 'mfsroot_load="YES"' > ${CD_DISC2}/boot/loader.conf
> -       _at_echo 'mfsroot_type="mfs_root"' >> ${CD_DISC2}/boot/loader.conf
> -       _at_echo 'mfsroot_name="/boot/mfsroot"' >> ${CD_DISC2}/boot/loader.conf
> +       _at_echo 'init_path="/usr/sbin/sysinstall"' > ${CD_DISC2}/boot/loader.conf
>         _at_cp -Rp ${CD_DISC2}/boot ${CD_DISC1}
>  .endif
>  .if !defined(NOPORTS)

How does sysinstall work with this change?  You do realize that we
mount the MFS as /, then mount the disk under /mnt, chroot to /mnt,
then mount the CD in /dist in the chroot and install from there?
Are you going to mount the CD as root or something?  It is probably
a lot simpler to simply let sysinstall always execute in a MFS root.

If you really want to rewrite the installation environment, then you
might want to talk that over on a mailing list first to get some input.
It's not a trivial task.

-- 

John Baldwin <jhb_at_FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
Received on Tue Jul 22 2003 - 10:06:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:16 UTC