Re: Fixing gcc 3.3 compile failures -- fix for net/netsaint-plugins

> > --- plugins/check_by_ssh.c.orig	Mon Apr 23 09:43:11 2001
> > +++ plugins/check_by_ssh.c	Tue Jul 22 05:05:52 2003
> > _at__at_ -191,7 +191,7 _at__at_
> >  	if (commands>1)
> >  		remotecmd=strscat(remotecmd,";echo STATUS CODE: $?;");
> >  
> > -	if (strlen (remotecmd) <= 1)
> > +	if (remotecmd==NULL)
> >  		usage ("No remotecmd\n");
> >  
> >  	comm = ssprintf(comm,"%s %s '%s'",comm,hostname,remotecmd);
> 
> This looks like more than a fix for a `compile failure'.  The
> replacement code has different semantics than the new code.
> What is the `compile failure' that was being fixed here?

I don't know, either. This patch was part of the port before I touched
it [1]. Perhaps one should write

if ((remotecmd==NULL) || (strlen (remotecmd) <= 1))

to be on the safe side?

Cheers,
 Simon
 
[1]:
http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/net/netsaint-plugins/files/patch-check_by_ssh.c?rev=1.1&content-type=text/plain