Re: PATCH: Disable 6 byte commands for USB, firewire, ATAPICAM

In article <20030724183246.X42809_at_root.org>, Nate Lawson wrote:
> Content-Type: TEXT/PLAIN; charset=US-ASCII
> 
> Attached is a patch that disables ever sending 6 byte commands to buses
> that do not support them. 

Got this trap, it's sitting there at the prompt, let me know how I can
help.  The clie should be acting as a USB mass storage device with
no entries in scsi_da.c for quirks.  I simply plugged in the device
in 'export mode' (which should be like plugging in a cf reader with
media inserted), and then observed these errors, then disconnected 
the device.  The device was 'hung' during these reset/bulk messages.

[root_at_pippin root]$ sysctl hw.usb.umass.debug=5
hw.usb.umass.debug: 0 -> 5
umass0: Sony Sony PEG Mass Storage, rev 1.10/1.00, addr 2
umass0: 8070i (ATAPI) over CBI with CCI (using CBI); quirks = 0x0000
umass0:0:0:-1: Attached to scbus0
(probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 0 0 0 24 0
(probe0:umass-sim0:0:0:0): CAM Status: SCSI Status Error
(probe0:umass-sim0:0:0:0): SCSI Status: Check Condition
(probe0:umass-sim0:0:0:0): UNIT ATTENTION asc:28,0
(probe0:umass-sim0:0:0:0): Not ready to ready change, medium may have changed
(probe0:umass-sim0:0:0:0): Retrying Command (per Sense Data)
umass0: CBI reset failed, TIMEOUT
umass0: CBI bulk-in stall clear failed, TIMEOUT
umass0: CBI bulk-out stall clear failed, TIMEOUT
daregister: setting no 6 byte
umass0: CBI reset failed, TIMEOUT
umass0: CBI bulk-in stall clear failed, TIMEOUT
umass0: CBI bulk-out stall clear failed, TIMEOUT
umass0: CBI reset failed, TIMEOUT
umass0: CBI bulk-in stall clear failed, TIMEOUT
umass0: CBI bulk-out stall clear failed, TIMEOUT
umass0: CBI reset failed, TIMEOUT
umass0: CBI bulk-in stall clear failed, TIMEOUT
umass0: CBI bulk-out stall clear failed, TIMEOUT
umass0: CBI reset failed, TIMEOUT
umass0: CBI bulk-in stall clear failed, TIMEOUT
umass0: CBI bulk-out stall clear failed, TIMEOUT
umass0: CBI reset failed, IOERROR
umass0: CBI bulk-in stall clear failed, IOERROR
umass0: CBI bulk-out stall clear failed, IOERROR
(da0:umass-sim0:0:0:0): got CAM status 0x4
(da0:umass-sim0:0:0:0): fatal error, failed to attach to device
(da0:umass-sim0:0:0:0): lost device
umass0: CBI reset failed, IOERROR
umass0: CBI bulk-in stall clear failed, IOERROR
umass0: CBI bulk-out stall clear failed, IOERROR
umass0: CBI reset failed, IOERROR
umass0: CBI bulk-in stall clear failed, IOERROR
umass0: CBI bulk-out stall clear failed, IOERROR
umass0: CBI reset failed, IOERROR
umass0: CBI bulk-in stall clear failed, IOERROR
umass0: CBI bulk-out stall clear failed, IOERROR
umass0: CBI reset failed, IOERROR
umass0: CBI bulk-in stall clear failed, IOERROR
umass0: CBI bulk-out stall clear failed, IOERROR
umass0: CBI reset failed, IOERROR
umass0: at uhub0 port 2 (addr 2) disconnected
umass0: detached


Fatal trap 12: page fault while in kernel mode
fault virtual address   = 0xdeadc10a
fault code              = supervisor read, page not present
instruction pointer     = 0x8:0xc034a346
stack pointer           = 0x10:0xc8625b88
frame pointer           = 0x10:0xc8625b88
code segment            = base 0x0, limit 0xfffff, type 0x1b
                        = DPL 0, pres 1, def32 1, gran 1
processor eflags        = interrupt enabled, resume, IOPL = 0
current process         = 26 (usb0)
kernel: type 12 trap, code=0
Stopped at      device_get_nameunit+0x6:        movl    0x2c(%eax),%eax
db> trace
device_get_nameunit(deadc0de,23,0,0,6) at device_get_nameunit+0x6
umass_cbi_state(c1c12300,c1c12500,6,c18b5000,6) at umass_cbi_state+0x659
usb_transfer_complete(c1c12300,2,c053635d,c18b5000,c19f5800,c05900c4) at usb_tra
nsfer_complete+0x1ba
uhci_abort_xfer(c1c12300,6,c8625c40,c02d7349,c1c12300) at uhci_abort_xfer+0x118
uhci_device_ctrl_abort(c1c12300,0,c053635d,14a,c19f5800) at uhci_device_ctrl_abo
rt+0x33
usbd_ar_pipe(c19f5800,c8625c60,c02d5594,c19f5800,c19f5d80) at usbd_ar_pipe+0x99
usbd_abort_pipe(c19f5800,c19f5d80,c19f5e00,c8625c7c,c02d62bd) at usbd_abort_pipe
+0x11
usbd_kill_pipe(c19f5800,c0349f4c,c19f5e00,1,c18d55c0) at usbd_kill_pipe+0x14
usb_free_device(c19f5e00,c19f5d80,c18d15a0,c18d5400,c18d15a0) at usb_free_device
+0x1d
usb_disconnect_port(c18d55c0,c18d5500,11,0,0) at usb_disconnect_port+0x12d
uhub_explore(c18d5400,c18aa120,c8625d0c,c02d2d01,c18aa120) at uhub_explore+0x2a1
usb_discover(c18aa120,0,5c,c052c40e,1770) at usb_discover+0x65
usb_event_thread(c18aa120,c8625d48,c053571a,312,423f0) at usb_event_thread+0x91
fork_exit(c02d2c70,c18aa120,c8625d48) at fork_exit+0xcf
fork_trampoline() at fork_trampoline+0x1a
--- trap 0x1, eip = 0, esp = 0xc8625d7c, ebp = 0 ---
db>

---
Mark
atkin901 at NOSPAM yahoo dot com
(!wired)?(coffee++):(wired);