On Tue, 3 Jun 2003, Jun Kuriyama wrote: > At Mon, 2 Jun 2003 10:10:26 +0000 (UTC), > Bruce Evans wrote: > > > > (2) Use correct dependency in sys/boot/i386/kgzldr. > > > > This is too hackish for me. Try using the same method as for lib/csu. > > I think you nmainly care about "make install" building things. This is > > from longstanding brokenness of installation of man pages which was > > cloned to brokenness of installation of FILES. > > Hmm, like this? I don't know which owner and mode should be used at > realinstall stage. Same as for csu (LIBOWN/LIBGRP/LIBMODE/LIBDIR). BINDIR should have been set to LIBDIR; LIBDIR can be used directly now the install rule is explicit. > Index: Makefile > =================================================================== > RCS file: /home/ncvs/src/sys/boot/i386/kgzldr/Makefile,v > retrieving revision 1.12 > diff -u -r1.12 Makefile > --- Makefile 30 Sep 2002 20:37:57 -0000 1.12 > +++ Makefile 3 Jun 2003 03:41:02 -0000 > _at__at_ -1,6 +1,5 _at__at_ > # $FreeBSD: src/sys/boot/i386/kgzldr/Makefile,v 1.12 2002/09/30 20:37:57 peter Exp $ > > -FILES= kgzldr.o > SRCS= start.s boot.c inflate.c lib.c crt.s sio.s > OBJS= ${SRCS:N*.h:R:S/$/.o/g} > CFLAGS= -ffreestanding > _at__at_ -15,7 +14,13 _at__at_ > BOOT_COMCONSOLE_PORT?= 0x3f8 > AFLAGS+=--defsym SIO_PRT=${BOOT_COMCONSOLE_PORT} > > +all: ${OBJS} kgzldr.o > + CLEANFILES needs to be adjusted too. > kgzldr.o: ${OBJS} > ${CC} ${LDFLAGS} -o ${.TARGET} ${OBJS} > + > +realinstall: > + ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m ${LIBMODE} \ > + kgzldr.o ${DESTDIR}${BINDIR} The continuation indent should be 4 as in csu/*/Makefile (except for the zombie i386 (aout) Makefile). > > .include <bsd.prog.mk> I think it should include <bsd.lib.mk>. BruceReceived on Tue Jun 03 2003 - 02:05:02 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:10 UTC