Re: Re Regression: Playing QT files from mplayer stopped working in 5.1

From: Ruslan Ermilov <ru_at_freebsd.org>
Date: Mon, 9 Jun 2003 13:54:21 +0300
On Mon, Jun 09, 2003 at 11:22:45AM +0200, Alexander Leidinger wrote:
> On Mon, 9 Jun 2003 10:28:33 +0200
> ted_at_NLnetLabs.nl (Ted Lindgreen) wrote:
> 
> > However, I guess that mplayer has had this error already, but that
> > a change in uthread_close.c as of May 31 has caused this problem
> > to show up now.
> > In particular: the unprotected usage of a very large value of "fd"
> > in "_thread_fd_table[fd]" leads to the segmentation violation.
> > 
> > Previously the systemcall just returned an error without getting
> > into a segmentation violation.
> 
> > Question:
> >   shouldn't _close in uthread_close.c do some sanity check on "fd"
> >   before using it as an array index?
> 
> Try the attached patch.
> 
Alexander,

This patch looks great.  Please commit it.


-- 
Ruslan Ermilov		Sysadmin and DBA,
ru_at_sunbay.com		Sunbay Software Ltd,
ru_at_FreeBSD.org		FreeBSD committer

Received on Mon Jun 09 2003 - 01:55:13 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:11 UTC