Re: Software watchdog patch

From: Hiten Pandya <hmp_at_FreeBSD.ORG>
Date: Sat, 21 Jun 2003 06:33:41 -0700
On Fri, Jun 20, 2003 at 09:47:07PM -0500, Sean Kelly wrote:
> Greetings.
> I look forward to any feedback, whether positive or negative.

	Hello Sean, this stuff looks really promising.  Anyways, I
	can't comment about the code as I have had no time to read it,
	but here are a few mdoc nitpicks I did:
	
Index: share/man/man4/watchdog.4
===================================================================
+is implemented via a trio of sysctl OIDs. When
+.Va debug.watchdog.enabled

	Hmm, the .Va should be replaced with .Li.  Also, it is necessary
	to remove all hard sentence breaks, ie. instead of:

		"via a trio of sysctl OIDs.  When..."
	
	It should be:

		"via a trio of sysctl OIDs.
		When..."
	
	Sysctls should be documented using .Li.

+.Sh SEE ALSO
+.Xr watchdogd 8 ,
+.Xr sysctl 8
+.Sh HISTORY

	Manual pages are first ordered by their section numbers, and
	then alphabetically, thus watchdogd(8)'s .Xr should be after
	sysctl(8).
	
+.Sh AUTHORS
+.An -nosplit
+The
+.Nm
+code and man page were written by
+.An Sean Kelly Aq smkelly_at_zombie.org .

	Use `manual page' instead of `man page'.
	
	Same sort of comments apply to the watchdogd(8) manual page.

	Hope that helps.
	Cheers.

	-- Hiten (hmp_at_FreeBSD.ORG)
Received on Sat Jun 21 2003 - 04:33:42 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:12 UTC