Re: Heads up: checking in change to ata-card.c

> In message <20030626.131417.101814768.imp_at_bsdimp.com>, "M. Warner Losh" writes:
> >Here's a better patch, basesd on wpaul's input.  Bill, can you try it
> >an see if it works for you?  If so, i would be better to commit this
> >one.  If not, I'll work with you to fix it. 
> 
> FYI, I have a no-name ("PCMCIA"/"CD-ROM") drive that also requires
> failure of the second IO range to be made non-fatal. How about just
> deleting the `else' clause as in the patch below? It seems that
> this can only affect CD-ROM drives that were otherwise not working,
> so it should be fairly safe.

This patch also tests good with my drive.

-Bill

--
=============================================================================
-Bill Paul            (510) 749-2329 | Senior Engineer, Master of Unix-Fu
                 wpaul_at_windriver.com | Wind River Systems
=============================================================================
      "If stupidity were a handicap, you'd have the best parking spot."
=============================================================================

> Ian
> 
> Index: ata-card.c
> ===================================================================
> RCS file: /dump/FreeBSD-CVS/src/sys/dev/ata/ata-card.c,v
> retrieving revision 1.14
> diff -u -r1.14 ata-card.c
> --- ata-card.c	17 Jun 2003 12:33:53 -0000	1.14
> +++ ata-card.c	26 Jun 2003 23:00:01 -0000
> _at__at_ -131,10 +131,6 _at__at_
>  			     start + ATA_ALTOFFSET, ATA_ALTIOSIZE);
>  	}
>      }
> -    else {
> -	bus_release_resource(dev, SYS_RES_IOPORT, rid, io);
> -	return ENXIO;
> -    }
>  
>      /* allocate the altport range */
>      rid = ATA_ALTADDR_RID;
> 
>