Re: /usr/src/libexec/talkd notification broken on pty's when user is using misc/screen ports in -CURRENT

* Vincent Poy <vince_at_oahu.WURLDLINK.NET> [ Date: 2003-06-30 ]
	[ w.r.t. /usr/src/libexec/talkd notification broken on pty's when user is using misc/screen ports in -CURRENT ]
> Greetings evertone:
> 
> /usr/src/libexec/talkd aka /usr/libexec/ntalkd appears to be broken when
> one runs the screen-3.9.15_1 from ports and has the pty sessions under
> screen.  Prior to running screen, ntalkd is showing the incoming talk
> request.  After running screen, the talk request doesn't show up on any of
> the pty's the user is currently using under the primary login pty.  The
> issue seems to be caused by the following commits done by jmallett:
> 
> src/libexec/talkd/announce.c v1.16, Thu Apr 3 05:13:27 2003 UTC jmallett
> src/libexec/talkd/extern.h v1.3, Thu Apr 3 05:13:27 2003 UTC jmallett
> src/libexec/talkd/print.c v1.12, Thu Apr 3 05:13:27 2003 UTC jmallett
> src/libexec/talkd/table.c v1.9, Thu Apr 3 05:13:27 2003 UTC jmallett
> src/libexec/talkd/talkd.c v1.14, Thu Apr 3 05:13:27 2003 UTC jmallett
> 
> which has the log:
> MFp4 _at_27667: WARNS=5 cleanup on i386.
>     Remove the unused FILE\ *tf from print_mesg args, and the
>     bogus passing in of an uninitialised FILE* for it.
> 
>     Call a timeval 'now' instead of 'clock' due to shadowing.
> 
>     Remove a nested localtime declaration.
> 
>     Make the delete invite argument match the ID type, u_int32_t.
> 
>     Use const for pointers to const items.
> 
>     Cast to long where printing as such.
> 
>     Include netinet/in.h for htonl/htons.
> 
> Reviewed by:	imp
> 
> Reverting to the following previous versions of the files and rebuilding
> ntalkd fixes the issue.
> 
> src/libexec/talkd/announce.c v1.15, Tue Feb 5 21:06:56 2002 UTC imp
> src/libexec/talkd/extern.h v1.2, Tue Feb 5 21:07:47 2002 UTC imp
> src/libexec/talkd/print.c v1.11, Mon Feb 18 20:35:19 2002 UTC mike
> src/libexec/talkd/table.c v1.8, Tue Feb 5 21:06:56 2002 UTC imp
> src/libexec/talkd/talkd.c v1.13, Tue Feb 5 21:06:56 2002 UTC imp

This may be a bit frustrating, but can you back out deltas by hand
and try to tell me which change it was that caused the problem?

Thanx,
juli.
-- 
juli mallett. email: jmallett_at_freebsd.org; efnet: juli; aim: bsdflata;
i have lost my way home early - i don't care cause i won't stay there.