Re: taskqueue patch

I wasn't involved in converting taskqueue from 4.x-style SWIs to kernel
threads so I can't be sure but this does look reasonable. I've been
wondering about the 'not exiting' diagnostic from init for a while
myself.

On Mon, 2003-11-10 at 05:10, Alfred Perlstein wrote:
> I noticed that init was complaining about processes not exiting
> when doing a transition to single user mode.  It appears
> that the problem is that the taskqueue kernel process is 
> started with RFNOWAIT but doesn't respect orderly shutdown
> signs.
> 
> Diff follows:
> 
> Index: subr_taskqueue.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/subr_taskqueue.c,v
> retrieving revision 1.19
> diff -u -r1.19 subr_taskqueue.c
> --- subr_taskqueue.c	6 Sep 2003 21:05:18 -0000	1.19
> +++ subr_taskqueue.c	10 Nov 2003 05:00:00 -0000
> _at__at_ -271,7 +271,7 _at__at_
>  
>  TASKQUEUE_DEFINE(thread, taskqueue_thread_enqueue, 0,
>  		 kthread_create(taskqueue_kthread, NULL,
> -		 &taskqueue_thread_proc, RFNOWAIT, 0, "taskqueue"));
> +		 &taskqueue_thread_proc, 0, 0, "taskqueue"));
>  
>  int
>  taskqueue_enqueue_fast(struct taskqueue *queue, struct task *task)
>