Re: lor on boot

On Thu, 2 Oct 2003, Mark Woodson wrote:

> On Thursday 02 October 2003 05:07 pm, Robert Watson wrote:
> > On Thu, 2 Oct 2003, Mark Woodson wrote:
> > > I'm getting a lor on a system just upgraded to sources from this
> > > morning.  The systems been running fine for the past month or so.
> >
> > What version of src/sys/net/netisr.c are you running with?
> 
>  * $FreeBSD: src/sys/net/netisr.c,v 1.4 2003/10/01 21:31:09 rwatson 
> Exp $
> 
> That's what I'm showing.  So it's from last night then.

Ah. Ok, this is because the if_rl driver holds the driver mutex across a
call to the interface input routine, resulting in holding the mutex across
a call into the remainder of the network stack.  The reason this showed up
for you now is that I temporarily enabled direct dispatch of the isr code
directly from the driver interrupt threads for an hour or so last night,
and you updated during that time.  I backed it out to work on two issues
-- one the possible reordering of packets (patch now bing reviewed), and
the other that a few drivers currently hold their lock over the call into
the remainder of the stack, which needs to be fixed.  If you cvsup, the
problem should go away.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert_at_fledge.watson.org      Network Associates Laboratories