Re: ATAng regression: cdcontrol close not working

Soren Schmidt wrote:
> 
> Anyhow if you loose the test for error in atapi-cd.c::acd_tray in the
> close case, does it work then ?

If you mean as below, no, that didn't help:

Index: atapi-cd.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/atapi-cd.c,v
retrieving revision 1.149
diff -u -r1.149 atapi-cd.c
--- atapi-cd.c  18 Oct 2003 17:24:51 -0000      1.149
+++ atapi-cd.c  30 Oct 2003 21:31:23 -0000
_at__at_ -1884,11 +1884,10 _at__at_

      if (cdp->cap.mechanism & MST_EJECT) {
         if (close) {
-           if (!(error = acd_start_stop(cdp, 3))) {
-               acd_read_toc(cdp);
-               acd_prevent_allow(cdp, 1);
-               cdp->flags |= F_LOCKED;
-           }
+            error = acd_start_stop(cdp, 3);
+           acd_read_toc(cdp);
+           acd_prevent_allow(cdp, 1);
+           cdp->flags |= F_LOCKED;
         }
         else {
             acd_start_stop(cdp, 0);

Lars
-- 
Lars Eggert <larse_at_isi.edu>           USC Information Sciences Institute