Michal Mertl wrote: > I found 2 bugs and some potential problems in bktr(4) code. > > Bug 1: > Compilation with options BKTR_USE_FREEBSD_SMBUS failes. Error is > that code tries to use iicbus which isn't defined where it looks for > it. I added it there and the compilation and detection goes fine. I don't > know how to actually test it though. > [...] Will anyone responsible take notice of this patch and commit it? > ------------------------------------------------------------------------ > > *** dev/bktr/bktr_reg.h.ori Sun Dec 8 10:40:14 2002 > --- dev/bktr/bktr_reg.h Sun Dec 8 10:40:38 2002 > *************** > *** 448,453 **** > --- 448,454 ---- > struct bktr_i2c_softc { > int bus_owned; > > + device_t iicbus; > device_t iicbb; > device_t smbus; > }; > *** dev/bktr/bktr_os.c.ori Sun Dec 8 10:39:13 2002 > --- dev/bktr/bktr_os.c Sun Dec 8 10:39:35 2002 > *************** > *** 499,513 **** > destroy_dev(bktr->tunerdev); > destroy_dev(bktr->bktrdev); > > - /* If this is unit 0, then destroy the alias entries too */ > - #if (__FreeBSD_version >=500000) > - if (unit == 0) { > - destroy_dev(bktr->vbidev_alias); > - destroy_dev(bktr->tunerdev_alias); > - destroy_dev(bktr->bktrdev_alias); > - } > - #endif > - > /* > * Deallocate resources. > */ > --- 499,504 ----Received on Wed Sep 03 2003 - 13:03:14 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:21 UTC