(unknown charset) Re: Intel SATA ICH5/5R 6300ESB support patches

Søren Schmidt writes:
| Poul-Henning Kamp wrote:
| > In message <200404042002.i34K2nop038808_at_ambrisko.com>, Doug Ambrisko writes:
| > 
| >>S?ren Schmidt writes:
| >>| > I put in a patch for geom for bio_taskqueue_remove.  Since ata code
| >>| > schedules bio_task it need to be cancelled when we abort and call
| >>| > biodone.  If we don't cancel this task then when the task is 
| >>| > run later we get a double free in UMA since we have cleaned up
| >>| > twice and called biodone twice for the same request.
| > 
| > Sos_at_ forwarded that patch and it won't fly, it has no chance of
| > working reliably on multi-cpu machines:
| > 
| > There is no guarantee that the task is still on the queue by the
| > time you try to remove it, and if is not, it is likely to be because
| > another CPU is already waiting for a lock in the ata driver in the
| > bio_taskqueue handler function, so we have no way to cancel that
| > other CPU's activity.
| > 
| > The correct solution is to not do the biodone when you cancel, but
| > let the already scheduled bio_taskqueue event to do so.
| 
| Actually I've solved this very differently by now, the problem was the 
| handling of the "in flight" request, that could cause bidone to be 
| called twice (which is plain wrong)...

Sounds good,

Doug A.