Re: cvs commit: src/usr.bin/tar Makefile bsdtar.1 bsdtar.c bsdtar.h bsdtar_platform.h matching.c read.c util.c write.c

Tim Kientzle <tim_at_kientzle.com> wrote:
> Brian F. Feldman wrote:
> > Tim Kientzle <tim_at_kientzle.com> wrote:
> > 
> >>Ruslan Ermilov wrote:
> >>
> >>>On Mon, Apr 05, 2004 at 02:32:18PM -0700, Tim Kientzle wrote:
> >>>
> >>>
> >>>>kientzle    2004/04/05 14:32:18 PDT
> >>>>
> >>>> FreeBSD src repository
> >>>>
> >>>> Added files:
> >>>>   usr.bin/tar          Makefile bsdtar.1 bsdtar.c bsdtar.h 
> >>>>                        bsdtar_platform.h matching.c read.c 
> >>>>                        util.c write.c 
> >>>> Log:
> >>>> Initial commit for bsdtar.
> >>>> 
> > 
> > What if you do compression as a worker thread?  I don't know how performance 
> > compares, but proof of concept is:
> > <http://green.homeunix.org/~green/libarchive_bz2thread.patch>
> 
> I'll take a look at your code, but I'm reluctant to spawn
> threads within a library for a number of reasons, ranging from
> client expectations (if you invoke the client-provided I/O
> routines within a separate thread, then you can encounter
> a situation where a non-threaded program might have to lock
> it's private data) to the potential for conflicts between
> threaded/non-threaded libc implementations.

Oh, I was only implementing it inside the libarchive default routines 
because it was easy.  I also think that if this is done to speed up tar, it 
should be done in tar and not libarchive.  What are you using to benchmark?  
I'm interested in seeing what happens with a worker thread/with a larger 
decompression buffer/etc.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green_at_FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\