Re: buildworld fails on src/sys/net80211/ieee80211_ioctl.c with opt_ipx.h not found

Hi again ;)

can someone commit the following patch (by Alex Lyashkov):
<<< cut here
--- src/sys/modules/wlan/Makefile.orig       Sat Apr 10 19:10:22 2004
+++ src/sys/modules/wlan/Makefile    Sat Apr 10 19:19:25 2004
_at__at_ -5,9 +5,12 _at__at_
 KMOD=  wlan
 SRCS=  ieee80211.c ieee80211_crypto.c ieee80211_input.c ieee80211_ioctl.c \
        ieee80211_node.c ieee80211_output.c ieee80211_proto.c
-SRCS+= bus_if.h device_if.h opt_inet.h
+SRCS+= bus_if.h device_if.h opt_inet.h opt_ipx.h

 opt_inet.h:
        echo "#define INET 1" > opt_inet.h
+
+opt_ipx.h:
+       echo "#define IPX 1" > opt_ipx.h

 .include <bsd.kmod.mk>
<<< cut here ;)

since I can confirm my assumption, that building world and
kernel+modules works, and building world+modules and kernel fails.
This patch should fix that, and makes wlan/Makefile to act as 
sys/modules/if_ef/Makefile .

Thanks ;)
Paulius

On 04 04 10, Paulius Bulotas wrote:
> On 04 04 10, Conrad Sabatier wrote:
> > On 10-Apr-2004 Paulius Bulotas wrote:
> > > buildworld fails on src/sys/net80211/ieee80211_ioctl.c with opt_ipx.h
> > > being not found. Since this change is 10 days old, maybe I've missed
> > > something in mailing list?
> > > Maybe the fix should be #ifdef'ing #include "opt_inet.h" and "opt_ipx.h"
> > > accordingly with #ifdef IPX and #ifdef INET?
> > 
> > You mean, I'm *not* the only one seeing this problem?  :-)
> > 
> > My report on this went completely ignored, so I finally assumed "it must just
> > be me".  :-)
> > 
> > It seems to me a simple insert in the Makefile (as seen in other locations)
> > would take care of this:
> > 
> >         echo "#define IPX 1" > opt_ipx.h
> > 
> > Why is this still broken???
> 
> are you compiling modules with world and not with kernel?
> 
> since opt_ipx.h probably should be created from some IPX protocol
> initialisation (if it's enabled in kernel config?), although I can't
> find anything related (or don't know how to look ;)
> 
> In sys/modules/if_ef/Makefile opt_ipx.h is created (since
> sys/net/if_ef.c uses opt_ipx.h and #ifdef IPX),
> in sys/modules/wlan/Makefile opt_ipx.h is not created (why?), but
> sys/net80211/* still compiles ok for most of people??? Something not
> right here ;)