Re: Page fault in rt_newaddrmsg on gif0 destruction

From: Andreas Kohn <andreas.kohn_at_gmx.net>
Date: Mon, 19 Apr 2004 10:51:13 +0200
On Mon, 19 Apr 2004 01:36:27 -0700
Luigi Rizzo <rizzo_at_icir.org> wrote:

> Ok i understand what is going on (thanks for the very detailed
> report, btw) -- basically the code was trying to use
> ifadd_byindex() after the information had been destroyed.
> 
> I think the attached patch (basically mving a block of code down
> in if_detach) should fix the problem.
> 
> Actually I believe this particular chunk of code should be moved
> even further down, possibly right before the final IF_AFDATA_UNLOCK(),
> because you cannot tell, a-priori, what information on the device
> the lower level routines expect to use, so zeroing the ifindex_table[]
> or calling destroy_dev() too early is probably a bug.
> 
> If you can try it (in the proposed form, or moving it at the end
> of if_detach) and let me khow how it works for you, i can commit
> the fix.

Hi,

thanks. I will try it as soon as I return home (in around 8 hours), and report back
then.

Regards,
Andreas
Received on Sun Apr 18 2004 - 23:51:25 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:51 UTC