On Wed, Apr 21, 2004 at 10:30:09AM +0200, Pawel Jakub Dawidek wrote: +> +> This patch fixed this problem. +> +> Your fix is probably only a workaround. +> The problem is more complex, because vn_start_write() is able to return 0 +> and mp == NULL when operation is not supported by file system. +> I'm not yet sure if we just can't fix vn_start_write() to return +> EOPNOTSUPP when needed, but there is a special case for this: +> +> if (error != EOPNOTSUPP) +> return (error); +> return (0); +> +> and I must figure out why. There are many vn_start_write() consumers, +> so this can take a while. +> Anyway, thank you for your report. Ok, quotactl() is probably the only place which use vn_start_write() not properly. Could you test this patch: http://people.freebsd.org/~pjd/patches/vfs_syscalls.c.2.patch The only different between yours patch and mine is that I'm returning EOPNOTSUPP instead of 0 if file system doesn't support quotas. -- Pawel Jakub Dawidek http://www.FreeBSD.org pjd_at_FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am!
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:51 UTC