Re: problems with altq

On Thu, Aug 05, 2004 at 01:16:37PM +0200, Divacky Roman wrote:
> On Thu, Aug 05, 2004 at 12:50:48PM +0200, Divacky Roman wrote:
> > On Wed, Aug 04, 2004 at 08:03:00PM +0200, Max Laier wrote:
> > > On Wednesday 04 August 2004 15:05, Divacky Roman wrote:
> > > >                 struct pf_altq          *altq, *a;
> > > >
> > > >                 if (pa->ticket != ticket_altqs_inactive) {
> > > >                         error = EBUSY;
> > > >                         break;
> > > >                 }
> > > >                 altq = pool_get(&pf_altq_pl, PR_NOWAIT);
> > > > 			         ^^^^^^^^^^
> > > > shouldnt this be initalized to NULL? at least its not nice to have it
> > > > uninitalized...
> > > 
> > > hum?
> > > $ cd /usr/src/sys/contrib/pf/net && grep pf_altq_pl *
> > > <...>
> > > pf_ioctl.c:     pf_state_pl = pf_altq_pl = pf_pooladdr_pl = NULL;
> > > pf_ioctl.c:     UMA_DESTROY(pf_altq_pl);
> > > pf_ioctl.c:             UMA_CREATE(pf_altq_pl,    struct pf_altq, "pfaltqpl");
> > > <...>
> > > 
> > > Or what are you thinking about?
> > 
> > pf/net/pf_ioctl.c:2032 and below 
> > 
> > hm... I got it wrong. I looked at it again and I changed type with variable
> > name ;(
> > 
> > hysteria.sk/~neologism/NEOLOGISM is my kernel config
> > hysteria.sk/~neologism/pf.conf is my whole pf config
> > 
> > I am compiling kernel with -Os (I know its not supported) I'll try with plain
> > -O
> >  
> > btw: why does the malloc has to be NOWAIT?
> 
> kernel compiled with -O and M_WAITOK doesnt help either

the problem is that I didnt have 
ALTQ_RED in my kernel config (thnx Pyun YongHyeon)

should it be announced a more friendly way?

roman