On Thursday 19 August 2004 10:08 am, Maxim Sobolev wrote: > Hi, > > Please review/comment on attached patch, which extends cdboot with > "Press any key to boot from CD" prompt inspired by Windows installation > CDs. IMHO this feature is quite useful for installation CDs, and > probably for other interactive one-shot CDs, to prevent machine from > booting off CD again after work is complete. If there is no objections, > I'd like to request repo copy from cdboot.s into cdboot.S and then > commit this change. My plan is to keep this feature turned off by > default, and provide make(1) knob to turn it one if necessary. > > Thanks! > > -Maxim Only thing I would change is to not use suffixes when they aren't necessary since that is the style of the rest of the file. That is, use 'xor %ah,%ah' rather than 'xorb %ah,%ah'. as(1) doesn't need them and the code is easier to read when the mnemnomics are less jagged. Also, if you wanted to get extra cute you would output a '.' each second during the countdown like Windows does. :) -- John Baldwin <jhb_at_FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.orgReceived on Thu Aug 19 2004 - 12:53:14 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:07 UTC