Re: [REVIEW/TEST] Rewritten floppy driver.

On Thu, Aug 19, 2004 at 11:15:27PM +0200, Poul-Henning Kamp wrote:
> In message <20040819211141.GA12219_at_unixpages.org>, Christian Brueffer writes:
> >
> >--k+w/mQv8wyuph6w0
> >Content-Type: text/plain; charset=us-ascii
> >Content-Disposition: inline
> >Content-Transfer-Encoding: quoted-printable
> >
> >On Thu, Aug 19, 2004 at 03:43:07PM +0200, Poul-Henning Kamp wrote:
> >>=20
> >> Please review and test this patch:
> >>=20
> >> 	http://phk.freebsd.dk/patch/fdc.patch
> >>=20
> >
> >The patch works for me, except mounting a write protected disk read-only:
> >
> >haakonia# mount -t msdosfs -r /dev/fd0 /mnt/private/
> >msdosfs: /dev/fd0: Read-only file system
> 
> This is a bug elsewhere and it is fixed on my "phk_bufwork" branch
> which will arrive in -current in about a month or so.
> 

I just noticed, that the patch breaks world:

cc -O -pipe -g -march=pentium
-I/usr/home/build/src/usr.sbin/fdcontrol/../fdread -Wsystem-headers
-Werror -Wall -Wno-format-y2k -Wno-uninitialized -c
/usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c
/usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c: In function `main':
/usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error:
`FD_DEBUG' undeclared (first use in this function)
/usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: (Each
undeclared identifier is reported only once
/usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: for each
function it appears in.)
*** Error code 1

Stop in /usr/home/build/src/usr.sbin/fdcontrol.
*** Error code 1

Stop in /usr/home/build/src/usr.sbin.
*** Error code 1

Stop in /usr/home/build/src.
*** Error code 1

Stop in /usr/home/build/src.
*** Error code 1

Stop in /usr/home/build/src.
haakonia#

- Christian

-- 
Christian Brueffer	chris_at_unixpages.org	brueffer_at_FreeBSD.org
GPG Key:	 http://people.freebsd.org/~brueffer/brueffer.key.asc
GPG Fingerprint: A5C8 2099 19FF AACA F41B  B29B 6C76 178C A0ED 982D