Re: buildworld problems when DESTDIR is specified?

On Tue, Aug 24, 2004 at 11:40:03AM +0400, Maxim Konovalov wrote:
> On Tue, 24 Aug 2004, 10:02+0300, Ruslan Ermilov wrote:
> 
> > On Mon, Aug 23, 2004 at 04:42:22PM -0700, Mayo Jordanov wrote:
> > > Hello,
> > >
> > > I'm trying to buildworld with today's (Monday) RELENG_5 (cvsupped
> > > sometime in the morning (also tried with one from sat/sun).
> > >
> > > When I just run make buildworld, it builds everything just fine, however
> > > it fails when DESTDIR is specified (for both, buildworld and
> > > installworld). The error occurs in stage 1.2, in gnu/usr.bin/gperf/doc.
> > >
> > > Whole stage 1.2 section is attached below.
> > >
> > > Can someone give me any pointers?
> > >
> > Yes.  DON'T DO THAT: do not specify DESTDIR as a command-line variable
> > to make(1) when doing a buildworld.  Do a normal "make buildworld",
> > then do a "make installworld" specifying the DESTDIR.
> >
> > P.S.  I know "make world DESTDIR=/foo" is broken at the moment due to
> > this.
> 
> It seems we need to fix the warning for 'make world'.  Now it suggests
> to define DESTDIR but not clear how to do that:
> 
> : Define DESTDIR to where you want to install FreeBSD,
> : including /, to override this warning and proceed as usual.
> 
> Moreover, a couple of days ago I was helping to a friend of mine to
> fix a problem with a broken build world, he had 'DESTDIR=/' in
> /etc/make.conf and 'make world' always failed for him.
> 
Recent make(1) is right about handling of command-line variables --
they stay command-line variables (a highest priority) forever.  The
new behavior is required by POSIX.  Unfortunately, it also breaks
the ``make world DESTDIR=/'', and there's no way you can unset/kill
the command-line variable, so I see only two solutions: 1) kill
"make world" completely, and 2) request that DESTDIR be set in
environment for "make world":  ``env DESTDIR=/foo make world''
should still work fine.


Cheers,
-- 
Ruslan Ermilov
ru_at_FreeBSD.org
FreeBSD committer