Re: BETA1 5.3 make world DESTDIR failure

From: Ruslan Ermilov <ru_at_FreeBSD.org>
Date: Wed, 25 Aug 2004 20:49:09 +0300
On Wed, Aug 25, 2004 at 10:37:07AM -0700, David O'Brien wrote:
> On Wed, Aug 25, 2004 at 04:47:22PM +0300, Ruslan Ermilov wrote:
> > as IMAKEENV (from Makefile.inc1) doesn't utilize DESTDIR.  I think I
> > know how to fix "make world DESTDIR=/foo" to make it work again -- we
> > need to convert all DESTDIR uses in Makefile.inc1 to be command-line
> > variables.  I'm currently testing this patch, and it looks promising:
> 
> Please also test 'make world' without DESTDIR in /etc/make.conf, but with
> 1. "HISTORICAL_MAKE_WORLD=yes" in /etc/make.conf
> 2. env HISTORICAL_MAKE_WORLD=yes make world
> before committing.
> 
That's pointless for this change.  If HISTORICAL_MAKE_WORLD is defined
and DESTDIR is not (irrelevant where), "make world" is just equivalent
to "make buildworld" followed by "make installworld".  Clearly, "make
buildworld" without DESTDIR works with and without this change.


Cheers,
-- 
Ruslan Ermilov
ru_at_FreeBSD.org
FreeBSD committer

Received on Wed Aug 25 2004 - 15:49:14 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:08 UTC