Re: bsdtar core dumps

From: David O'Brien <obrien_at_freebsd.org>
Date: Wed, 25 Aug 2004 11:17:30 -0700
On Tue, Aug 24, 2004 at 03:17:28PM -0700, Sean McNeil wrote:
> > > SM>> You cannot use a va_list twice. As soon as someone call
> > > va_arg() on the SM>> ap all the aps in the calling functions get
> > > invalid. The only thing that SM>> can and must be done is that the
> > > function that did the va_start() must SM>> call va_end.
...
> I missed one in vfwprintf.c.  I needs a va_end(orgap) just like above.
> 
> Also, I've searched all of src and found one additional place that there
> is a va_copy without a va_end.
> 
> contrib/gnu-sort/lib/version-etc.c
> 
> All other uses appear to be properly matched.

Can you please make a new, complete patch?
I'll commit it ASAP.
 
-- 
-- David  (obrien_at_FreeBSD.org)
Received on Wed Aug 25 2004 - 16:17:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:08 UTC