Re: PLEASE TEST: IPI deadlock avoidance patch

On Thu, 26 Aug 2004, Craig Boston wrote:

> On Thu, Aug 26, 2004 at 11:18:34AM -0700, Doug White wrote:
> > Okay, for those of you experiencing the data corruption issue, I need to
> > know the following:
>
> Sure, I'll do what I can to help track this down.
>
> > . cvsup date & time for the affect kernel(s)
>
> "Sometime yesterday" is the closest I can come up with by memory.
> /usr/sup/src-all/checkouts.cvs:RELENG_5 seems to indicate 8/25/2004
> 05:39 UTC, which sounds right.
>
> > . branch you're tracking
>
> RELENG_5 + IPI patch
> (manually reapplied after each cvsup)
>
> > . revision of src/sys/kern/kern_lock.c - I'm checking for a specific set
> >   of commits here
>
> /usr/src/sys/kern/kern_lock.c:
>      $FreeBSD: src/sys/kern/kern_lock.c,v 1.74 2004/08/16 15:01:22 kan Exp $

DING DING DING -- we have a winner. This rev is bogus and was backed out.
Back up to a working kernel, cvsup, and re-build.  The IPI patch has been
merged so you won't need to reapply it.
> Possibly.  The only other thing recently changed on there is using
> gvinum instead of regular vinum.  But there's no hard evidence either
> way -- my stripe size is much bigger than the size of the corrupt
> sections, and the frequency of the corrupt files appearing seems to be
> about the same as the frequency of deadlocks I had prior to the IPI
> patch.  Both facts are completely circumstantial and could easily be
> coincidence.  Or it could be something else entirely.

Good to know that there was some bogosity in gvinum too that you might be
hitting :)

-- 
Doug White                    |  FreeBSD: The Power to Serve
dwhite_at_gumbysoft.com          |  www.FreeBSD.org