Re: Processes blocked on getblk or ufs

From: Scott Long <scottl_at_freebsd.org>
Date: Sun, 08 Feb 2004 23:45:13 -0700
Peter Losher wrote:
> On Sat, 7 Feb 2004, Chip Norkus wrote:
> 
> 
>>>woo,  Scott's commit seem to fix this problem for me!
>>>
>>
>>I think I can throw a 'me too' in here.  A build (make -j8 world) which
>>would reliably lock up one of my 2650s no longer does so.  This is
>>extremely encouraging. :)  Thanks so much for the hard work on this!
> 
> 
> Any chance this can be backported to RELENG_5_2?  Because as it is now 5.2
> is unusable on Dell systems using the aac driver.
> 
> -Peter

Can you try the attached patch?

Scott

Index: aac.c
===================================================================
RCS file: /usr/ncvs/src/sys/dev/aac/aac.c,v
retrieving revision 1.81
diff -u -r1.81 aac.c
--- aac.c	9 Nov 2003 09:17:20 -0000	1.81
+++ aac.c	9 Feb 2004 06:41:57 -0000
_at__at_ -1290,8 +1290,10 _at__at_
 	cm->cm_flags |= AAC_CMD_MAPPED;
 
 	/* put the FIB on the outbound queue */
-	if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY)
+	if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY) {
+		aac_unmap_command(cm);
 		aac_requeue_ready(cm);
+	}
 
 	return;
 }
Received on Sun Feb 08 2004 - 21:47:46 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:42 UTC