Sony V505BX ATA panic

Hi Soren,

It seems the following commit broke my Sony V505BX:

%sos         2004/01/30 11:16:08 PST
%
%  FreeBSD src repository
%
%    Modified files:
%      sys/dev/ata          ata-all.c ata-queue.c
%    Log:
%    Be more robust in the probe. We dont want to get into a loop with
%    reinitting when we try to identify devices. If they dont interrupt
%    on identify we retry once. If this fails we simply ignore that device.
%
%    Revision  Changes    Path
%    1.203     +10 -11    src/sys/dev/ata/ata-all.c
%    1.19      +28 -13    src/sys/dev/ata/ata-queue.c

It panics right after the message

ad0: 57231MB <FUJITSU MHS2060AT> [116280/16/63] at ata0-master UDMA100
ata1-slave: TIMEOUT - ATAPI_IDENTIFY no interrupt
ata1-slave: TIMEOUT - ATAPI_IDENTIFY no interrupt
acd0: CDRW <UJDA745 DVD/CDRW> at ata1-master UDMA33

A black magic below makes my notebook happy again.  Verbose boot is
there: http://news.macomnet.ru/~maxim/stuff/dmesg.boot

Index: ata-all.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-all.c,v
retrieving revision 1.203
diff -u -r1.203 ata-all.c
--- ata-all.c	30 Jan 2004 19:16:08 -0000	1.203
+++ ata-all.c	14 Feb 2004 15:43:20 -0000
_at__at_ -567,7 +567,7 _at__at_
 	    while (retries-- > 0) {
 		request->device = atadev;
 		request->timeout = 5;
-		request->retries = -1;
+		request->retries = 3;
 		request->u.ata.command = command;
 		request->flags = (ATA_R_READ | ATA_R_IMMEDIATE);
 		request->data = (caddr_t)atadev->param;
%%%

Now it boots this way:

[...]
ad0: 57231MB <FUJITSU MHS2060AT> [116280/16/63] at ata0-master UDMA100
ata1-slave: TIMEOUT - ATAPI_IDENTIFY retrying (3 retries left) LBA=0
acd0: CDRW <UJDA745 DVD/CDRW> at ata1-master UDMA33

Thanks!

-- 
Maxim Konovalov