On Thu, Feb 26, 2004 at 05:22:33PM -0800, Brooks Davis wrote: [...] > This commit broke PXE booting: > > ----- > ru 2004/02/09 06:11:58 PST > > FreeBSD src repository > > Modified files: > sys/boot/i386 Makefile.inc > sys/boot/i386/boot0 Makefile > sys/boot/i386/boot2 Makefile > sys/boot/i386/btx/btx Makefile > sys/boot/i386/btx/btxldr Makefile > sys/boot/i386/btx/lib Makefile > sys/boot/i386/cdboot Makefile > sys/boot/i386/kgzldr Makefile > sys/boot/i386/loader Makefile > sys/boot/i386/mbr Makefile > sys/boot/i386/pxeldr Makefile > Log: > - Factor out -nostdlib to an upper level Makefile.inc. > > - Now that bsd.prog.mk deals with programs linked with -nostdlib > better, and has a notion of an "internal" program, use PROG > where possible. This has a good impact on the contents of > .depend files and causes programs to be linked with cc(1). > > XXX: boot2 couldn't be converted as it's actually two programs. > > Tested on: i386, amd64 > ----- > > I verified this with a binary search using perforce syncing against a > local checkout of //depot/vendor/freebsd/src/. At 2004/02/09:06:15 > pxeldr works. At 2004/02/09:06:16 it dies. The only files that change > in this time frame are these files in sys/boot. > > Specifically the problem is rev 1.73 of sys/boot/i386/loader/Makefile. A > tip of tree checkout with rev 1.73 removed PE boots. > So, does backing it out solve your problem, if you downgrade only sys/boot/ to the date prior to this commit? I doubt it, because I've verified that my changes produce identical binaries. The only difference now is because vers.o and ../btx/lib/crt.o are linked into the loader.sym binary in a slightly different order. By making some insignificant changes to loader/Makefile I've been able to verify that I still get the identical binaries (for all of sys/boot/i386/) with my changes, after I saw your first complaint in this thread. Cheers, -- Ruslan Ermilov FreeBSD committer ru_at_FreeBSD.org
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:44 UTC