Re: [PATCH] IPSec fixes

From: Jun-ichiro itojun Hagino <itojun_at_itojun.org>
Date: Wed, 14 Jan 2004 09:37:32 +0900 (JST)
> > http://sources.zabbadoz.net/freebsd/patchset/110-ipsec-netkey-key.diff
> 	dunno if it is correct or not.  need more investigation.

	location of key_freesp() are wrong (you end up dereference freed
	pointer on ipseclog() because you call key_freesp() beforehand).
	other than that, those key_freesp() are needed.  thanks.

	as for key_sp_unlink(), i don't think the patch is correct.
	even if you do not call key_sp_unlink() in key_spdflush(), spd entries
	will get unlink'ed in key_timehandler().  therefore the end result
	will be the same.

itojun
Received on Tue Jan 13 2004 - 15:37:35 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:37 UTC