Re: release failure on today's sourcer

On Fri, Jan 23, 2004 at 07:45:33AM -0800, Edwin Culp wrote:
> For informational purposes, make release seems to have
> stoped at doFS.sh today.  This is the first release
> failure I've had in a bit.  It's probably already
> fixed, but just in case.
> 
> ed
> 
> Copying if_sf.ko to /R/stage/mfsfd/modules
> *** Error code 1 (ignored)
> sh -e /usr/src/release/scripts/doFS.sh bsdlabel ""
> /R/stage/mfsroot/mfsroot /R/stage /mnt  4320
> /R/stage/mfsfd 8000 minimum3
> + export BLOCKSIZE=512
> + DISKLABEL=bsdlabel
> + shift
> + MACHINE=-m /R/stage/mfsroot/mfsroot
> + shift
> + FSIMG=/R/stage
> + shift

Odd.  The code is:

DISKLABEL=$1; shift
MACHINE=${1:+"-m $1"}; shift
FSIMG=$1; shift
...

So this should have produced

+ DISKLABEL=bsdlabel
+ shift
+ MACHINE=
+ shift
+ FSIMG=/R/stage/mfsroot/mfsroot
+ shift

since the second argument is "".

> + RD=/mnt
> + shift
> + MNT=4320
> + shift
> + FSSIZE=/R/stage/mfsfd
> + shift
> + FSPROTO=8000
> + shift
> + FSINODE=minimum3
> + shift
> + FSLABEL=
> + shift
> shift: can't shift that many
> *** Error code 2
> 
> Stop in /usr/src/release.
> 
I've just checked with most fresh shell sources, and everything
works as expected.


Cheers,
-- 
Ruslan Ermilov
FreeBSD committer
ru_at_FreeBSD.org