Re: [PATCH] Witness breakage

On Thu, Jul 08, 2004 at 05:15:19PM -0400, John Baldwin wrote:
> On Thursday 08 July 2004 01:10 pm, John Baldwin wrote:
> > On Wednesday 07 July 2004 02:20 pm, Daniel Lang wrote:
> > > Hi,
> > >
> > > as announced, here is the PR I just filed: kern/68779
> > > it includes a gdb stack trace and some very basic analysys.
> > > The crash dump and kernel are currently available, so if
> > > anyone is interested in some particular data, please let me
> > > know in the next few hours.
> > >
> > > Thanks and best regards,
> > >  Daniel
> >
> > Ok, I think I've found at least one bug in witness that came in with the
> > witness_checkorder() changes a few months ago that can be triggered by
> > preemption because of thread migration.  For those seeing witness problems,
> > please try this patch:
> 
> Ok, after the 476 million e-mails about how to spell 'implicitly', I've fixed 
> that part.  Now, can someone _please_ test it who has been having problems?
> 

I can't build a kernel or I would have tested this by now.  No one
appears to read the freebsd-current mailing list because I reported
this several hours ago.

cc -c -O -pipe -march=pentium4 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -std=c99 -g -nostdinc -I-  -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000  -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror  vers.c
linking kernel.debug
bootp_subr.o(.text+0x1f0e): In function `bootpc_init':
/usr/src/sys/nfsclient/bootp_subr.c:1660: undefined reference to `nfs_diskless_valid'
bootp_subr.o(.text+0x222b):/usr/src/sys/nfsclient/bootp_subr.c:1746: undefined reference to `nfsv3_diskless'
bootp_subr.o(.text+0x2275):/usr/src/sys/nfsclient/bootp_subr.c:1750: undefined reference to `nfsv3_diskless'


-- 
Steve