At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote: >On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote: >> >> a) how about if we print a warning and exit if DESTDIR is >> not defined? Are there "important" uses of `make world' >> which do not use DESTDIR? > >My thoughts exactly. See attached patch. I imagine we could debate the best wording to use for the warning message, but I do think this patch would be an improvement for our users. If it saves a few users from a trashed system, it will be a valuable change. In my quick testing, it seemed to do the right things. One other thing we might want to change is the part where we: # Set a reasonable default .MAIN: all I am not so sure that is a reasonable default. Someone who roams into /usr/src and types a plain `make' should probably be told to read the documentation for what to do. However, this does not bother me much. I think `make world' is the bigger issue. -- Garance Alistair Drosehn = gad_at_gilead.netel.rpi.edu Senior Systems Programmer or gad_at_freebsd.org Rensselaer Polytechnic Institute or drosih_at_rpi.eduReceived on Tue Jul 13 2004 - 22:04:34 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:01 UTC