Re: CVSUP and 5.2.1 RELEASE

From: Jon Noack <noackjr_at_alumni.rice.edu>
Date: Wed, 14 Jul 2004 04:26:22 -0500
On 07/14/04 03:56, Michael Nottebrock wrote:
> On Wednesday 14 July 2004 04:24, Garance A Drosihn wrote:
>> At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote:
>>> On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote:
>>>> a) how about if we print a warning and exit if DESTDIR is
>>>>    not defined?  Are there "important" uses of `make world'
>>>>    which do not use DESTDIR?
>>>
>>> My thoughts exactly. See attached patch.
>>
>> Actually, the target should end with some kind of failure, in case
>> someone has a script that does:
>>      make world && do-next-thing
> 
> Why should make world DESTDIR=/my/jail && cd etc && make distribution 
> DESTDIR=/my/jail fail?

It won't fail.  If you read the patch and thread a bit more closely 
you'll note that the warning and failure happen only if DESTDIR is not 
defined.  As you are defining DESTDIR, you won't see any change in 
behavior/output.

Jon
Received on Wed Jul 14 2004 - 07:26:27 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:01 UTC