Re: Some netgraph node global locking patches

From: Gleb Smirnoff <glebius_at_freebsd.org>
Date: Wed, 14 Jul 2004 22:42:40 +0400
On Wed, Jul 14, 2004 at 08:36:01PM +0200, Poul-Henning Kamp wrote:
P> >Yes it does. But qsort() already used in ng_ppp is as much recursive as
P> >qsort_r() is. It will help us to get rid of global variable.
P> >I Cc phk_at_ to this mail, because he copied qsort() to libkern from libc.
P> 
P> It was put there to get rid of a couple of badly implemented bubble
P> sorts.
P> 
P> It is true that qsort() is recursive, but it is limited to log2(N)
P> levels and kernel programmers hopefully don't routinely sort arrays
P> of hundreds of things in the kernel.

>From a snap view I see no problems copying qsort_r() to libkern. What
do you think? It will help us to get rid of global in ng_ppp.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
Received on Wed Jul 14 2004 - 16:42:44 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:01 UTC