Re: 5.3-RELEASE TODO

On Wed, 21 Jul 2004, Frode Nordahl wrote:

> On Jul 16, 2004, at 11:17, Björn Grönvall wrote:
> 
> > PR bin/61718 fixes a bunch of bugs in rpc.lockd, please try it.
> 
> Yes, rpc.lockd is useless without this patch.
> 
> Can someone please commit it?

It looks like much if not all of it was committed on 20040716; commit
message below.  Are any specific things that appear to be missing that
weren't merged?

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert_at_fledge.watson.org      Principal Research Scientist, McAfee Research


revision 1.17
date: 2004/07/16 12:50:10;  author: mr;  state: Exp;  lines: +1 -1
After talking to Colin,
apply the patch of bin/61718 (which should include/elimatate kern/61122
also).
It seems to fix a few annoying bugs.

PR:             bin/61718, kern/61122
Submitted by:   bg_at_sics.se ohartman_at_mail.physik.uni-mainz.de
----------------------------
revision 1.18
date: 2004/07/16 19:30:59;  author: mr;  state: Exp;  lines: +0 -0
Forced commit to actually list the changes of bin/61718, as requested by
sam.

The attached patch fixes a number of problems present in rpc.lockd.

 1)

 Nfslocklist_head.lf_first is overwritten because of an off-by-one-bug
 that happens when clnt_cache_next_to_use is incorrectly incremented.

 2)

 'struct sockaddr *addr' inside 'struct file_lock' is set to point to
 the result from svc_getrpccaller(). This value is malloc:ed inside the
 rpc libraries and is free:ed when clnt_destroy() is called. Fix,
 maintain a copy of the result.

 3)

 The loop inside retry_blockingfilelocklist() that uses 3 pointers ifl,
 nfl, and pfl thrashes the list pointed to by
 blockedlocklist_head.lf_first. Fix, use a simpler loop. The new loop
 does not preserve list order but the order is immaterial anyways. See
 also revison 1.6-1.7 and kern/61122.

 4)

 struct file_lock
         char client_name[SM_MAXSTRLEN];

 and

 struct host
         char name[SM_MAXSTRLEN];

 Be careful to not create open (non 0 terminated) C strings and later
 passing them to e.g syslog. Fix, make sure that the strings are always
 terminated with 0. When at it, move the strings to the end of the
 structs and make them variable length. This saves about 1000 bytes for
 every malloc:ed struct.

 5)

 The newfl = malloc(sizeof(struct file_lock)) memory was never properly
 bzero:ed.

 Minor changes:

 A)

 Nlmtonlm4(0) made assumptions about struct layouts.

 B)

 Don't close stdout and stderr when debugging (-d option).

 C)

 Remove unused pid_t locker and int fd in struct file_lock.

 D)

 s/printf/debuglog/

 E)

 Remove redundant sleep(1) and call to debuglog().

 Cheers,
 Bj<F6>rn