Re: build is broken after gcc import

Maxim Maximov wrote:
> Maxim Maximov wrote:
> >Now traceroute builds fine, thanks! But buildkernel fails (after 
> >successful buildworld):

Thanks for testing the patch, it has now been committed.

> >--------------------------------------------------------------
> > >>> stage 3.1: making dependencies
> >--------------------------------------------------------------
> >cd /usr/obj/usr/src/sys/ULTRA;  MAKEOBJDIRPREFIX=/usr/obj 
> >MACHINE_ARCH=i386  MACHINE=i386  CPUTYPE= 
> >GROFF_BIN_PATH=/usr/obj/usr/src/i386/legacy/usr/bin 
> >GROFF_FONT_PATH=/usr/obj/usr/src/i386/legacy/usr/share/groff_font 
> >GROFF_TMAC_PATH=/usr/obj/usr/src/i386/legacy/usr/share/tmac 
> >DESTDIR=/usr/obj/usr/src/i386  _SHLIBDIRPREFIX=/usr/obj/usr/src/i386 
> >INSTALL="sh /usr/src/tools/install.sh" 
> >PATH=/usr/obj/usr/src/i386/legacy/usr/sbin:/usr/obj/usr/src/i386/legacy/usr/bin:/usr/obj/usr/src/i386/legacy/usr/games:/usr/obj/usr/src/i386/usr/sbin:/usr/obj/usr/src/i386/usr/bin:/usr/obj/usr/src/i386/usr/games:/sbin:/bin:/usr/sbin:/usr/bin 
> >/usr/obj/usr/src/make.i386/make KERNEL=kernel depend -DNO_MODULES_OBJ
> >rm -f .olddep
> >if [ -f .depend ]; then mv .depend .olddep; fi
> >/usr/obj/usr/src/make.i386/make _kernel-depend
> >cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs 
> >-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline 
> >-Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. 
> >-I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica 
> >-I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter 
> >-I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath 
> >-I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm 
> >-D_KERNEL -include opt_global.h -finline-limit=8000 --param 
> >inline-unit-growth=100 --param large-function-growth=1000 
> >-mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding 
> >/usr/src/sys/i386/i386/genassym.c
> >cc1: error: unrecognized command line option "-fformat-extensions"
> >*** Error code 1

It seems you have cvsup'ed at a bad time.  The -fformat-extensions
option is a FreeBSD-specific (and NetBSD, I've been told) option, and
is not in GCC baseline.  It has been merged back in revision 1.24 of
src/contrib/gcc/toplev.c.  Can you check that you have the latest
version of this file?  If you don't just re-cvsup and try again.

> And attached patch fixes the problem.

This patch is incorrect, as should be obvious after the explanation
above.

Cheers,
Maxime