Re: -fformat-extensions (was: Re: build is broken after gcc import)

On Wed, Jul 28, 2004 at 11:23:32PM +0200, Marius Strobl wrote:
> On Wed, Jul 28, 2004 at 06:34:55PM +0200, Marius Strobl wrote:
> > On Wed, Jul 28, 2004 at 06:06:19PM +0200, Maxime Henrion wrote:
> > > Maxim Maximov wrote:
> > > > Maxim Maximov wrote:
> > > > >cc1: error: unrecognized command line option "-fformat-extensions"
> > > > >*** Error code 1
> > > 
> > > It seems you have cvsup'ed at a bad time.  The -fformat-extensions
> > > option is a FreeBSD-specific (and NetBSD, I've been told) option, and
> > > is not in GCC baseline.  It has been merged back in revision 1.24 of
> > > src/contrib/gcc/toplev.c.  Can you check that you have the latest
> > > version of this file?  If you don't just re-cvsup and try again.
> > > 
> > 
> > Looks rather like Alexander forgot to commit the patch below, taken
> > from his http://people.freebsd.org/~kan/gcc341.tar.gz.
> > 
> 
> Ok, that patch misses the part for c-opts.c which is also needed to
> recognize "-fformat-extensions". But I don't see how this option
> is supposed to work, even before the GCC 3.4.2 import c-format.c
> didn't use flag_format_extensions but seems to use these extensions
> unconditionally.

You are correct. This flag was not really doing anything for the most of
FreeBSD-5 lifetime. I will probably remove it altogether in 6.x.

I committed the fix for now.

--
Alexander Kabaev