In message <200406011125.03166.jhb_at_FreeBSD.org>, John Baldwin writes: >On Saturday 29 May 2004 05:21 pm, Poul-Henning Kamp wrote: >> Some embedded boxes do not have the keyboard controller, and this >> patch adds a timeout so they do not get stuck waiting for it to >> become ready. >> >> Please test that this patch does not have any effect on normal >> PC architecture machines. > >I'd prefer that you explicitly set %cx to a timeout value after the cli >instead of relying on its value being zero in the caller. ENOMOREBYTES :-( I guess the logical thing would be to inline it rather than have it be a function, that saves the cx initializtion, the call and the return. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk_at_FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.Received on Tue Jun 01 2004 - 22:55:14 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:55 UTC