Re: Can the disklabel(8) link go now?

From: Scott Long <scottl_at_freebsd.org>
Date: Fri, 04 Jun 2004 03:30:55 -0600
My vote is 'not right now'.  disklabel is a very fundamental command
to BSD, so if you intend to remove it then I suggest that you do the
following:

1. Mark it as 'deprecated' everywhere.  All documentation, manual
pages, etc.  If you can make it so that an invocation of 'disklabel'
prints out a deprecation warning, that would be good also.
2. After 5-STABLE branches, remove it from HEAD.
3. Leave it in 5-STABLE until EOL.

Scott

Ruslan Ermilov wrote:
> Gang,
> 
> I'd like to remove the old compatibility link from bsdlabel(8)
> to disklabel(8).  I think the dust has settled enough to allow
> this to be done now (and before 5.3-RELEASE):
> 
> %%%
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/src/sbin/bsdlabel/Makefile,v
> retrieving revision 1.19
> diff -u -r1.19 Makefile
> --- Makefile	11 Jan 2004 09:11:10 -0000	1.19
> +++ Makefile	4 Jun 2004 09:20:31 -0000
> _at__at_ -8,17 +8,16 _at__at_
>  #MAN=	bsdlabel.5
>  MAN+=	bsdlabel.8
>  
> -.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "alpha" || \
> -    ${MACHINE_ARCH} == "amd64"
> -LINKS=	${BINDIR}/bsdlabel ${BINDIR}/disklabel
> -MLINKS=	bsdlabel.8 disklabel.8
> -.endif
> -
>  DPADD=	${LIBGEOM}
>  LDADD=	-lgeom
>  
>  .include <bsd.prog.mk>
>  
> +afterinstall:
> +.if exists(${DESTDIR}${BINDIR}/disklabel)
> +	rm -f ${DESTDIR}${BINDIR}/disklabel
> +.endif
> +
>  test: ${PROG}
>  	sh ${.CURDIR}/runtest.sh
>  
> %%%
> 
> What do you think?
> 
> 
> Cheers,
Received on Fri Jun 04 2004 - 00:31:23 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:55 UTC