Re: weak implementation of threads has problems - kse fix attached

On Mon, 2004-06-07 at 20:21, Tim Robbins wrote:
> On Mon, Jun 07, 2004 at 07:57:35PM -0700, Sean McNeil wrote:
> 
> > 
> > Up front, I'd like to make a few apologies:
> > 
> > 1) I am sorry for the length of this email.
> > 2) Although some very valid opinions have been expressed, I respectfully
> > have to disagree.  This email will hopefully strengthen my position.
> > 
> > The problem:
> > 
> > (If you just want kse threads to work for you properly, just apply the
> > patch at the end of this email and try it out).
> > 
> > kse threads on amd64 doesn't work with gnome.  It crashes applications
> > here and there.  gnome-terminal is essentially unusable.
> > 
> > I strongly believe this to be a binding issue.  I've examined rtld and
> > I'm satisfied that it is behaving appropriately, so I took a long hard
> > look at how FreeBSD has implemented the pthread interface, how it is
> > being used, and how people expect it to behave.
> [...]
> 
> Your patch looks useful in its own right, but GNOME, Firefox, Mozilla
> and XMMS have not crashed once for me since I fixed context restoring in
> libpthread on amd64. Strong references cannot possibly make the old
> version of context.S work correctly.
> 
> I would be interested in hearing whether you still have problems with
> libpthread and GNOME after updating your system, both with and without
> nss_ldap.

Great, Tim!  I did indeed get this fix when testing my changes.  The
patch I posted still has some redeeming value, but yours was the key to
gnome stability for me as well.

Sean